fix: detect server subfolder in init#566
Merged
domdomegg merged 4 commits intomodelcontextprotocol:mainfrom Oct 27, 2025
Merged
fix: detect server subfolder in init#566domdomegg merged 4 commits intomodelcontextprotocol:mainfrom
domdomegg merged 4 commits intomodelcontextprotocol:mainfrom
Conversation
domdomegg
previously approved these changes
Oct 3, 2025
Member
|
Thanks! Are you able to fix the merge conflicts and we can get this shipped 🚀 |
MaxKless
force-pushed
the
detect-subfolder-in-init
branch
from
7a3e409 to
514c92d
Compare
Contributor
Author
|
awesome, glad to hear it @domdomegg! I rebased and fixed the merge conflicts :) |
rdimitrov
reviewed
Oct 6, 2025
Member
rdimitrov
left a comment
rdimitrov
left a comment
There was a problem hiding this comment.
Thanks! Left a small comment 👍
cmd/publisher/commands/init.go
Outdated
| // If we're in a subdirectory, use the current folder name | ||
| if subfolder != "" { | ||
| if cwd, err := os.Getwd(); err == nil { | ||
| folderName := filepath.Base(cwd) |
Member
There was a problem hiding this comment.
It seems we use subfolder as a boolean even though it's a string. Wouldn't it be better to reuse the subfolder variable we already have?
For example if it's != "" construct the path using it (and avoid reading the base path again), otherwise proceed as if we are in the root repo.
Contributor
Author
There was a problem hiding this comment.
you're completely right, I pushed a fix
Contributor
Author
|
Hey! Any update on this? Looks like I got an approval and fixed the comment from the other review so is it ready to be merged? |
domdomegg
approved these changes
Oct 27, 2025
Swathi-MuraliSrinivasan
pushed a commit
to Swathi-MuraliSrinivasan/paychex-mcp-registry
that referenced
this pull request
Nov 20, 2025
<!-- Provide a brief summary of your changes --> ## Motivation and Context Discussion from this issue: modelcontextprotocol#538 We want to make it clearer that repo name & server name do not HAVE to be the same, especially in monorepos. @tadasant this seems like a minor thing that doesn't have to be documented specifically, lmk if you disagree :) ## How Has This Been Tested? Tested the init flow locally, running the built `init` command from a subfolder and the repo root. ## Breaking Changes No ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [x] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [x] My code follows the repository's style guidelines - [x] New and existing tests pass locally - [x] I have added appropriate error handling - [x] I have added or updated documentation as needed ## Additional context <!-- Add any other context, implementation notes, or design decisions -->
slimslenderslacks
pushed a commit
to slimslenderslacks/registry
that referenced
this pull request
Dec 18, 2025
<!-- Provide a brief summary of your changes --> ## Motivation and Context Discussion from this issue: modelcontextprotocol#538 We want to make it clearer that repo name & server name do not HAVE to be the same, especially in monorepos. @tadasant this seems like a minor thing that doesn't have to be documented specifically, lmk if you disagree :) ## How Has This Been Tested? Tested the init flow locally, running the built `init` command from a subfolder and the repo root. ## Breaking Changes No ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [x] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [x] My code follows the repository's style guidelines - [x] New and existing tests pass locally - [x] I have added appropriate error handling - [x] I have added or updated documentation as needed ## Additional context <!-- Add any other context, implementation notes, or design decisions -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Discussion from this issue: #538
We want to make it clearer that repo name & server name do not HAVE to be the same, especially in monorepos.
@tadasant this seems like a minor thing that doesn't have to be documented specifically, lmk if you disagree :)
How Has This Been Tested?
Tested the init flow locally, running the built
initcommand from a subfolder and the repo root.Breaking Changes
No
Types of changes
Checklist
Additional context