Conversation
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
|
The failing check is expected, see #732 |
domdomegg
left a comment
domdomegg
left a comment
There was a problem hiding this comment.
Am okay to merge, will defer to you. But I think I actually prefer if we can keep the workflow primarily bash commands as easier to debug e.g. locally than custom actions.
I like that too but when running govulncheck locally it is a bit weird unfortunately. The reason is it uses the Go version available on your host (not the one specified in the go.mod file) so if people are not aware of this it may give false positive results since almost always the host version of Go is equal or greater than the one in the go.mod file. |
<!-- Provide a brief summary of your changes --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> Better to use the action with proper versioning instead of latest. ## How Has This Been Tested? <!-- Have you tested this in a real application? Which scenarios were tested? --> ## Breaking Changes <!-- Will users need to update their code or configurations? --> ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [ ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ ] My code follows the repository's style guidelines - [ ] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed ## Additional context <!-- Add any other context, implementation notes, or design decisions --> Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
2 participants
Motivation and Context
Better to use the action with proper versioning instead of latest.
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context