Fix Resource::Embedded not setting @resource in initialize#220
Merged
koic merged 1 commit intomodelcontextprotocol:mainfrom Feb 4, 2026
Conversation
The `initialize` method was missing the assignment of `@resource`, causing the resource method to always return `nil` and `to_h` to return an incorrect hash with an empty resource value. Added comprehensive tests to verify the fix and prevent regression.
atesgoral
approved these changes
Feb 4, 2026
koic
deleted the
fix_resource_embedded_not_setting_resource_in_initialize
branch
koic
added a commit
that referenced
this pull request
Feb 14, 2026
Some new features and fixes have been added, and it seems like a good time to cut a release. - #103 - #223 - #218 - #221 - #225 - #224 - #220 For now, the features completed so far can be included in this release, and subsequent feature proposals can continue to be incorporated into future releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
initializemethod was missing the assignment of@resource, causing the resource method to always returnnilandto_hto return an incorrect hash with an empty resource value.How Has This Been Tested?
Added comprehensive tests to verify the fix and prevent regression.
Breaking Changes
None.
Types of changes
Checklist