docs: add GPG validation onboarding step#966
Merged
UlisesGascon merged 1 commit intomainfrom Jan 12, 2024
Merged
Conversation
RafaelGSS
approved these changes
Dec 4, 2023
Member
RafaelGSS
left a comment
RafaelGSS
left a comment
There was a problem hiding this comment.
LGTM with a tiny suggestion.
| * Be added to the GitHub [security-release team](https://github.com/orgs/nodejs/teams/security-release) in the Node.js and nodejs-private orgs | ||
| * Have a single, high quality SSH key added to the "dist" user on the primary www server (see below for guidelines regarding SSH key quality) | ||
| * Add your GPG key to your GitHub account for verification. [Github Guide](https://docs.github.com/en/authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account). | ||
| * Check that the key is added in your profile: `https://github.com/your-username.gpg` |
Member
There was a problem hiding this comment.
Can we check it using gh? So in the future, we could integrate it on @node-core/utils.
Member
Author
There was a problem hiding this comment.
Yeah! 100% possible I think as this is not a protected endpoint. Let me see If I can create a PR for it
richardlau
approved these changes
Dec 4, 2023
targos
approved these changes
Dec 4, 2023
|
docs/gpg-validation |
marley1989
approved these changes
Jan 11, 2024
| * Be added to the GitHub [security-release team](https://github.com/orgs/nodejs/teams/security-release) in the Node.js and nodejs-private orgs | ||
| * Have a single, high quality SSH key added to the "dist" user on the primary www server (see below for guidelines regarding SSH key quality) | ||
| * Add your GPG key to your GitHub account for verification. [Github Guide](https://docs.github.com/en/authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account). | ||
| * Check that the key is added in your profile: `https://github.com/your-username.gpg` |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| * Check that the key is added in your profile: `https://github.com/your-username.gpg` | ||
| * Open a PR to add their GPG key to the nodejs/node [README.md](https://github.com/nodejs/node/#release-keys) | ||
| * Once landed, the key should be cherry-picked to all active release staging branches (i.e. the active `vMM.x-staging` branches). | ||
| * Any future updates to the key should also be cherry-picked to all active release staging branches. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
Author
|
I will merge it, as seems that we are on the same page and it has been open for a while 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #965