rules: add co-authored-by-is-trailer#93
Merged
tniessen merged 1 commit intonodejs:mainfrom Jan 16, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 74.88% 75.65% +0.77%
==========================================
Files 18 19 +1
Lines 442 456 +14
==========================================
+ Hits 331 345 +14
Misses 111 111
Continue to review full report at Codecov.
|
Trott
approved these changes
Jan 15, 2022
richardlau
approved these changes
Jan 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule ensures that
Co-authored-byis a trailer and does not appear at the beginning of any non-trailer lines. Violations of this rule have caused some commits to not be attributed to co-authors in the core repository.cc @nodejs/build @nodejs/node-core-utils
Refs: nodejs/node-core-utils#602