Conversation
Member
|
Ref your nodejs/node#37308 (comment) about TSC consensus, I'll hold on reviewing this for now. Shout when there's news from TSC 😄 |
Contributor
Author
|
nodejs/node#37308 has landed :) |
mmarchini
approved these changes
Feb 26, 2021
Contributor
mmarchini
left a comment
mmarchini
left a comment
There was a problem hiding this comment.
We should really move this to an Action 😅
Member
Without a doubt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the bot add a
needs-cilabel to all PRs that make changes to files that affects thenodebinary.Refs: nodejs/node#37308