http: accept 0xFF as a valid character in header values#65
Closed
lukiano wants to merge 1 commit intonodejs:masterfrom
Closed
http: accept 0xFF as a valid character in header values#65lukiano wants to merge 1 commit intonodejs:masterfrom
lukiano wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
|
Oh gosh. Good catch! |
indutny
approved these changes
Sep 2, 2020
Member
indutny
left a comment
indutny
left a comment
There was a problem hiding this comment.
LGTM. I'll add a test myself right after landing.
indutny
pushed a commit
that referenced
this pull request
Sep 2, 2020
PR-URL: #65 Reviewed-By: Fedor Indutny <[email protected]>
Member
Contributor
Author
|
Hi and sorry to bother again, do you know by chance when this will land on Node.JS ? Thanks and regards. |
4 tasks
Member
|
Hey, sorry for a delay! There has been some release scheduling conflicts that had to be addressed. I've submitted a PR nodejs/node#35435 |
lpinca
pushed a commit
to nodejs/node
that referenced
this pull request
Oct 4, 2020
PR-URL: #35435 Refs: nodejs/llhttp#65 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Oct 6, 2020
PR-URL: #35435 Refs: nodejs/llhttp#65 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
MylesBorins
pushed a commit
to nodejs/node
that referenced
this pull request
Nov 3, 2020
PR-URL: #35435 Refs: nodejs/llhttp#65 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
MylesBorins
pushed a commit
to nodejs/node
that referenced
this pull request
Nov 16, 2020
PR-URL: #35435 Refs: nodejs/llhttp#65 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35435 Refs: nodejs/llhttp#65 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
abhishekumar-tyagi
pushed a commit
to abhishekumar-tyagi/node
that referenced
this pull request
May 5, 2024
elijah-charbel
added a commit
to elijah-charbel/llhttp
that referenced
this pull request
Jul 29, 2025
PR-URL: nodejs/llhttp#65 Reviewed-By: Fedor Indutny <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I took a stab at trying to fix the issues I'm seeing in nodejs/node#27711 (comment)
I wasn't able to generate a test case using the test suite of this project based on
.mdfiles, as I couldn't recreate the0xFFiso-8859-1 character. However I downloaded the Node source code and copied over the generated C files of this project and then compiled Node itself. When I ran the short program described in the comment above it worked successfully.I'd like to hear thoughts and opinions on this change.
Kind regards.