This repository was archived by the owner on Sep 2, 2023. It is now read-only.
Conversation
guybedford
approved these changes
Jul 29, 2020
bmeck
approved these changes
Jul 29, 2020
Member
|
It'd be good to give folks more than an hour to review and suggest changes. |
Contributor
Author
|
@ljharb My assumption was that people can always edit the notes afterwards if they want to update something. |
SMotaal
reviewed
Aug 26, 2020
| * Jordan: Clarification: Does PR change nodejs to node? Which direction would be align? | ||
| * Bradley: Would prefer `node:` if we align. Could support both like we did with `getFormat`. | ||
| * Jordan: `node` is the name of the binary, using `node:` seems consistent. | ||
| * Myles: `node:` could be registered, not registered yet. |
There was a problem hiding this comment.
@MylesBorins I think we talked about this last year, so I am 100% in favour of this move, no strong feelings for either node or nodejs personally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #536