Windows CI: synchronise Node.js versions with those used for Linux/macOS CI#768
Merged
mhdawson merged 1 commit intonodejs:masterfrom Jul 21, 2020
Merged
Conversation
Member
|
I'm happy to land this update, but I don't think we've use it for the team's testing. It may have been used externally by the Microsoft people who were contributing to N-API a while back. |
NickNaso
approved these changes
Jul 20, 2020
Member
NickNaso
left a comment
NickNaso
left a comment
There was a problem hiding this comment.
LGTM. Thanks to update this configuration. It could be useful on working on a PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updates to VS2017 so tests will compile - see #766 for further context.
Example successful build - https://ci.appveyor.com/project/lovell/node-addon-api/builds/34119509
Appveyor doesn't appear to currently run for PRs etc, so someone with the relevant access level to this repo may need to switch it back on again.