Conversation
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
=========================================
- Coverage 98.05% 95.86% -2.2%
=========================================
Files 15 15
Lines 567 581 +14
=========================================
+ Hits 556 557 +1
- Misses 11 24 +13
Continue to review full report at Codecov.
|
bin/git/git-node-apply
Outdated
| const paths = require('./../../lib/paths'); | ||
| const { run, runAsync } = require('../../lib/run'); | ||
| const fs = require('fs'); | ||
| const CLI = require('../../lib/CLI'); |
There was a problem hiding this comment.
I think this should be ../../lib/cli.
|
Note that this is still WIP, I would still need to find some time to port the rest of the bash scripts to Node.js scripts. Although I have been using this fork locally to land stuff anyways. |
|
I totally did not mean to hit approve meant to comment... |
|
@joyeecheung tried to port bash scripts to node-script and this is currently what i have. (I this help great! 👍 ) |
|
@cPhost Thanks, but the porting is not really what's blocking me right now...The more I use it, the more I prefer the |
|
Also after landing this before publishing to npm, we need to ensure the Windows compatibility. |
|
After thinking about sub commands i think we should have then and and implement single land script that does all the things at once with the subcommands. |
03da45f to
6c578ef
Compare
|
Recording of working prototype: https://asciinema.org/a/6i3gFDSAr7L6fYPSEaMrW0asO |
9ed39bd to
f99e6f4
Compare
|
I've been using it for about two months now and it seems to be working pretty well. There are still a few things that need to be addressed:
I think when I finished 3 this should be ready to land on master. |
a4618aa to
4752dee
Compare
|
Docs done. Demos: Landing multiple commits: https://asciinema.org/a/148627 This should be ready to merge. |
|
This Looks good to me :) |
|
I am going to merge this and release a new version. Let's see how it works in the wild. |
This was #98 , opening a new PR because the repo has been transferred so I need to update the branch of my fork instead.