fix: use git apply not system apply#432
Conversation
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
=======================================
Coverage 77.13% 77.13%
=======================================
Files 21 21
Lines 1496 1496
=======================================
Hits 1154 1154
Misses 342 342 Continue to review full report at Codecov.
|
87ca7c2 to
bb4a1c4
Compare
|
There is some regression. For example with this commit: v8/v8@50af617
|
bb4a1c4 to
96d2b66
Compare
|
@targos should be fixed up now - working with the supplied commit. |
96d2b66 to
3fb6b9b
Compare
|
It broke one of the V8 commands: https://ci.nodejs.org/job/node-update-v8-canary/1366/display/redirect I'll have a look later if I have time. |
|
@targos ah dang i know what it is - i missed two files when i was grepping. Fix up in a bit. |
Closes #421.
Switches to
git applyvs systemapply, since the available options for systemapplydiffer between systems.cc @targos