chore: split CI builds to new files#464
Merged
priyank-p merged 1 commit intonodejs:masterfrom Aug 6, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #464 +/- ##
==========================================
+ Coverage 76.88% 82.58% +5.69%
==========================================
Files 28 34 +6
Lines 1752 1665 -87
==========================================
+ Hits 1347 1375 +28
+ Misses 405 290 -115
Continue to review full report at Codecov.
|
Contributor
|
Not saying this needs to be done this way, but I think doing this refactor one or couple of class per commit would have made reviewing this way easier. Less changes to look at per commit means it is easier to spot a mistake :) On the contrary, if you were missing an import of a class then eslint would have complained but doing it that way is still better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #455:
This is the remainder of that work - the file was inscrutably long and so i felt this would be more maintainable in this form. Specs are passing, but please take a good look if you can to make sure i didn't whiff on anything!
cc @nodejs/node-core-utils