fix: switch to undici for requests to fix stream close errors#666
fix: switch to undici for requests to fix stream close errors#666aduh95 merged 3 commits intonodejs:mainfrom
Conversation
When updating WPT resources, the `wpt` command would sometimes throw a `ERR_STREAM_PREMATURE_CLOSE` error. Switching to `undici` fixes this issue. The `undici` `fetch` function is only supported on Node 16+. After discussing with the team, we agreed that dropping support for Node 14 in this tool was acceptable.
Codecov ReportBase: 83.41% // Head: 83.41% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #666 +/- ##
=======================================
Coverage 83.41% 83.41%
=======================================
Files 37 37
Lines 4131 4131
=======================================
Hits 3446 3446
Misses 685 685 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
The commit message would need to be updated to reflect that this is a breaking change. Calling it fix is probably not right as we're dropping support for Node.js 14.x. We may want to add an Footnotes
|
|
For whoever is going to merge: add a line with |
Fixes #626
When updating WPT resources, the
wptcommand would sometimes throw aERR_STREAM_PREMATURE_CLOSEerror. Switching toundicifixes this issue.The
undicifetchfunction is only supported on Node 16+. After discussing with the team, we agreed that dropping support for Node 14 in this tool was acceptable (#626 (comment)).