Skip to content

lib: enable support for zoslib on z/OS#2600

Merged
gengjiawen merged 1 commit intonodejs:mainfrom
ibmruntimes:up_zoslibinclude
Jul 15, 2022
Merged

lib: enable support for zoslib on z/OS#2600
gengjiawen merged 1 commit intonodejs:mainfrom
ibmruntimes:up_zoslibinclude

Conversation

@alexcfyung
Copy link
Contributor

@alexcfyung alexcfyung commented Jan 27, 2022 •
edited
Loading

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

zoslib is needed to support node.js on z/OS

@alexcfyung alexcfyung mentioned this pull request Jan 27, 2022
Merged
@mhdawson
Copy link
Member

mhdawson commented Jun 28, 2022

@nodejs/node-gyp could somebody re-run the github actions? I'm pretty sure the failures will not be related to the change as it only affects z/OS but would be good to get the CI green.

@richardlau
Copy link
Member

richardlau commented Jun 28, 2022

I don't appear to have the option of rerunning the actions for this PR.

@mhdawson
Copy link
Member

mhdawson commented Jun 28, 2022

I thought maybe it was just my level of access as I did not either. Is there some reasonable change we can push to retriggger. I guess we could add/remove a blank line unless somebody has better ideas.

@gengjiawen
Copy link
Member

gengjiawen commented Jun 29, 2022

I thought maybe it was just my level of access as I did not either. Is there some reasonable change we can push to retriggger. I guess we could add/remove a blank line unless somebody has better ideas.

rebase maybe a better idea.

@gengjiawen
Copy link
Member

gengjiawen commented Jul 13, 2022

@alexcfyung Can you do a rebase for this, I don't seem have permission to edit this PR.

@richardlau
Copy link
Member

richardlau commented Jul 13, 2022

cc @zsw007

@alexcfyung @gabylb @zsw007
lib: enable support for zoslib on z/OS
0344a1f 
Check if zos-base.h is in the directory identified by environment
variable ZOSLIB_INCLUDES if set; otherwise search for it from a set of
candidates under nodeRootDir. Then pass it as
-Dzoslib_include_dir=<path-found> to gyp_main.py for use in common.gypi
to set 'includes_dir' when compiling addons.

Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
@zsw007 zsw007 force-pushed the up_zoslibinclude branch from a1e419e to 0344a1f Compare July 14, 2022 18:38
@zsw007
Copy link
Contributor

zsw007 commented Jul 14, 2022 •
edited
Loading

cc @zsw007

Thanks for the heads up. I went ahead and rebased this PR @mhdawson

@gengjiawen gengjiawen merged commit 83c0a12 into nodejs:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexcfyung @mhdawson @richardlau @gengjiawen @zsw007