This repository was archived by the owner on Jun 18, 2021. It is now read-only.
Rename nodereport module to node-report#52
Closed
rnchamberlain wants to merge 2 commits intonodejs:masterfrom
rnchamberlain:project-rename-1
Closed
Rename nodereport module to node-report#52rnchamberlain wants to merge 2 commits intonodejs:masterfrom rnchamberlain:project-rename-1
rnchamberlain wants to merge 2 commits intonodejs:masterfrom
rnchamberlain:project-rename-1
Conversation
Provides code, documentation, test and demo changes required for the migration of the nodereport project to node-report. The main changes are in the build, tests and demos that use the module name, and in the name of the report file. Remaining changes are mostly in comments. Internal variable and macro names are not changed.
Contributor
Author
|
@mhdawson @richardlau this PR is almost identical to #43, would you mind reviewing again - many thanks! |
richardlau
approved these changes
Feb 3, 2017
LICENCE.md
Outdated
| Copyright (c) 2016 node-report contributors | ||
| -------------------------------------------------- | ||
|
|
||
| *nodereport contributors listed at <https://github.com/nodejs/nodereport/blob/master/AUTHORS>* |
Member
There was a problem hiding this comment.
https://github.com/nodejs/nodereport/blob/master/AUTHORS was deleted under #13.
README.md
Outdated
| setSignal("SIGUSR2|SIGQUIT"); | ||
| setFileName("stdout|stderr|<filename>"); | ||
| setDirectory("<full path>"); | ||
| setVerbose("yes|no"); |
Member
There was a problem hiding this comment.
We could keep the nodereport. prefixes if we add the following to the beginning (like the earlier code example)
var nodereport = require('node-report/api');
Contributor
Author
There was a problem hiding this comment.
good idea, done
demo/api_call.js
Outdated
| case 0: | ||
| response.writeHead(200,{"Content-Type": "text/plain"}); | ||
| response.write("\nRunning NodeReport API demo... refresh page to trigger NodeReport"); | ||
| response.write("\nRunning node-report API demo... refresh page to trigger NodeReport"); |
Member
There was a problem hiding this comment.
s/NodeReport/report for consistency
demo/loop.js
Outdated
| response.writeHead(200,{"Content-Type": "text/plain"}); | ||
| response.write("\nRunning NodeReport looping application demo. Node process ID = " + process.pid); | ||
| response.write("\nRunning node-report looping application demo. Node process ID = " + process.pid); | ||
| response.write("\n\nRefresh page to enter loop, then use 'kill -USR2 " + process.pid + "' to trigger NodeReport"); |
Member
There was a problem hiding this comment.
s/NodeReport/report for consistency
package.json
Outdated
| "version": "1.0.7", | ||
| "description": "Diagnostic NodeReport", | ||
| "homepage": "https://github.com/nodejs/nodereport#readme", | ||
| "description": "Diagnostic Report for Node", |
Correct invalid URL for contributors, improve README code example, remove remaining references to NodeReport in demos, correct project description in package.json.
rnchamberlain
added a commit
that referenced
this pull request
Feb 9, 2017
Provides code, documentation, test and demo changes required for the migration of the nodereport project to node-report. The main changes are in the build, tests and demos that use the module name, and in the name of the report file. Remaining changes are mostly in comments. Internal variable and macro names are not changed. PR-URL: #52 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Contributor
Author
|
Landed as a590cd9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides code, documentation, test and demo changes required for the migration of the nodereport project to node-report. The main changes are in the build, tests and demos that use the module name, and in the name of the report file. Remaining changes are mostly in comments. Internal variable and macro names are not changed.
This supercedes #43
CI: https://ci.nodejs.org/view/post-mortem/job/nodereport-continuous-integration/44/