Cannot read property 'Symbol(type)' of undefined

[davedoesdev]

• Version: v11.2.0
• Platform: Linux david-Latitude-E6440 4.18.0-11-generic openssl-cli.exe child process stdin problem on Windows #12-Ubuntu SMP Tue Oct 23 19:22:37 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
• Subsystem: http2

Sample program:

const { createServer, connect } = require('http2');
createServer().listen(7000, () => {
    connect('http://localhost:7000', session => {
        session.request({ ':method': 'POST' }).end(() => {
            session.destroy();
        });
    });
});

Exception:

internal/http2/core.js:2009
          this[kSession][kType] === NGHTTP2_SESSION_SERVER &&
                        ^

TypeError: Cannot read property 'Symbol(type)' of undefined
    at ClientHttp2Stream.[kMaybeDestroy] (internal/http2/core.js:2009:25)
    at ShutdownWrap.afterShutdown [as oncomplete] (internal/http2/core.js:1547:26)
    at ClientHttp2Stream._final (internal/http2/core.js:1841:14)
    at callFinal (_stream_writable.js:617:10)
    at process.internalTickCallback (internal/process/next_tick.js:72:19)

Cause is destroy() happening (and setting [kSession] to undefined) before afterShutdown then calls [kMaybeDestroy]().

The example shows a simple repro but if timing is wrong then it can also 'just happen' (session is destroyed while stream is shutting down.

[Trott]

Fixed in 895fe2f

[davedoesdev]

Thanks!