fs: fix .write() not coercing non-string values#1102
Closed
Fishrock123 wants to merge 1 commit intonodejs:v1.xfrom
Closed
fs: fix .write() not coercing non-string values#1102Fishrock123 wants to merge 1 commit intonodejs:v1.xfrom
Fishrock123 wants to merge 1 commit intonodejs:v1.xfrom
Conversation
Fishrock123
added
the
fs
Contributor
Author
|
test is just adapted from |
Contributor
|
LGTM. Thanks @Fishrock123, merged in |
Member
|
@brendanashworth since @Fishrock123 is a collaborator it's probably best to let him merge it. I personally would have preferred a bit more time to have some more eyes on this before merging as it's not as trivial as a doc fix. |
Contributor
|
@rvagg sorry, you're right, I probably should've let it sizzle - then I buried it with another commit. Won't happen again :) |
Contributor
Author
|
The behavior appears to have been incorrect from the start: 7ca77ea#diff-9a205ef7ee967ee32efee02e58b3482dR484 No tests were added when the API was added, and thus it was not caught. |
This was referenced Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #1098
relevant docs: https://github.com/iojs/io.js/blob/v1.x/doc/api/fs.markdown#fswritefd-data-position-encoding-callback
R=anyone