test: fix variables quoated when path has spaces on Windows#1122
Closed
shigeki wants to merge 1 commit intonodejs:v1.xfrom
Closed
test: fix variables quoated when path has spaces on Windows#1122shigeki wants to merge 1 commit intonodejs:v1.xfrom
shigeki wants to merge 1 commit intonodejs:v1.xfrom
Conversation
Contributor
There was a problem hiding this comment.
This is really hard to read... Can you make it something like
cmd = '"' + process.execPath + '" ' +
'"' + common.fixturesDir + '/test-regress-GH-4015.js"';
Contributor
|
Thanks @shigeki, +1 with the following comments:
|
External commands are enclosed in double quotes so as not to be failed when spaces are included in execPATH especially on Windows.
Contributor
Author
|
@piscisaureus Thanks for your reviewing. I fixed styles and the commit message. The commit of vcbuild.bat was removed because it's already fixed, though I should have taken care of it more. PTAL. |
Contributor
|
@shigeki Great work, lgtm! |
shigeki
pushed a commit
that referenced
this pull request
Mar 13, 2015
Paths used on the Windows command line need to be enclosed in double quotes, or they'll be parsed incorrectly when there are spaces in the path. PR-URL: #1122 Reviewed-by: Bert Belder <bertbelder@gmail.com>
Contributor
|
Thanks for your patience and good work, @shigeki. |
Contributor
Author
|
@piscisaureus Thanks for revising my commit message. It gets more clear and better English. |
This was referenced Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes test failures when a path of the repository has spaces on Windows as it was pointed out in
c7ad320#commitcomment-10043315
and also fixes missed
setin vcbuild.batr= @piscisaureus