errors, url: migrate to use internal/errors.js#11360
Closed
bougarfaoui wants to merge 5 commits intonodejs:masterfrom
Closed
errors, url: migrate to use internal/errors.js#11360bougarfaoui wants to merge 5 commits intonodejs:masterfrom
bougarfaoui wants to merge 5 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
errors
80 tasks
joyeecheung
reviewed
Feb 14, 2017
lib/url.js
Outdated
| Url.prototype.parse = function(url, parseQueryString, slashesDenoteHost) { | ||
| if (typeof url !== 'string') { | ||
| throw new TypeError('Parameter "url" must be a string, not ' + typeof url); | ||
| throw new errors.TypeError('ERR_INVALID_ARG_TYPE','url','String',url); |
Member
There was a problem hiding this comment.
Linter should complain here, there needs to be a space following the comma. Can you run make lint to check this?
lib/url.js
Outdated
| } else if (typeof obj !== 'object' || obj === null) { | ||
| throw new TypeError('Parameter "urlObj" must be an object, not ' + | ||
| (obj === null ? 'null' : typeof obj)); | ||
| throw new errors.TypeError('ERR_INVALID_ARG_TYPE','obj','Object',obj); |
jasnell
added
the
semver-major
Member
|
@bougarfaoui Thanks so much for putting this together. Sorry that it is dragging out for so long due to being a semver-major change. Could you rebase and also squash your commits (I think all the changes should be one commit, right?). Thanks! |
fhinkel
reviewed
May 23, 2017
Member
fhinkel
left a comment
fhinkel
left a comment
There was a problem hiding this comment.
Are there any tests that cover these changes?
Member
|
I'm closing this because it's been inactive for quite a while. Feel free to reopen or ping a collaborator to get it reopened if needed. |
3 tasks
Contributor
|
I'll follow up |
refack
removed
blocked
Contributor
|
The errors in |
Contributor
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate url.js to use internal/errors.js
Refs: #11273
cc @jasnell .
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
errors, url