doc: modernize and fix code examples in https.md#12171
Closed
vsemozhetbyt wants to merge 3 commits intonodejs:masterfrom
vsemozhetbyt:https.md
Closed
doc: modernize and fix code examples in https.md#12171vsemozhetbyt wants to merge 3 commits intonodejs:masterfrom vsemozhetbyt:https.md
vsemozhetbyt wants to merge 3 commits intonodejs:masterfrom
vsemozhetbyt:https.md
Conversation
Provide relevant test file path, add missing option.
nodejs-github-bot
added
doc
lpinca
approved these changes
Apr 3, 2017
cjihrig
approved these changes
Apr 3, 2017
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM, although casual readers might find the use of test/fixtures/ a bit confusing.
Member
|
@cjihrig I thought the same but then I took a look at the other examples and |
jasnell
approved these changes
Apr 3, 2017
Contributor
Author
|
Yes, I was a bit surprised too, but these test paths are already there in some other examples, so I've just tried to conform. It seems it is easier to find these files in the code base than to make them somehow for quick testing. |
Contributor
Author
|
Landed in 5059363 |
vsemozhetbyt
added a commit
that referenced
this pull request
Apr 5, 2017
* Replace `var` by `const`. * Comment out ellipses. * Update code example (provide relevant file path, add missing option). PR-URL: #12171 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
* Replace `var` by `const`. * Comment out ellipses. * Update code example (provide relevant file path, add missing option). PR-URL: nodejs#12171 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 18, 2017
* Replace `var` by `const`. * Comment out ellipses. * Update code example (provide relevant file path, add missing option). PR-URL: #12171 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
I've backported to v6.x assuming the changes are relevant. Let me know if this should be backed out |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
* Replace `var` by `const`. * Comment out ellipses. * Update code example (provide relevant file path, add missing option). PR-URL: #12171 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
* Replace `var` by `const`. * Comment out ellipses. * Update code example (provide relevant file path, add missing option). PR-URL: nodejs/node#12171 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, https
varbyconst