test: fix test-cli-syntax assertions on windows#12212
Merged
not-an-aardvark merged 1 commit intonodejs:masterfrom Apr 4, 2017
Merged
test: fix test-cli-syntax assertions on windows#12212not-an-aardvark merged 1 commit intonodejs:masterfrom
not-an-aardvark merged 1 commit intonodejs:masterfrom
Conversation
Contributor
Author
3 tasks
Member
|
We should land this ASAP (once CI passes) to fix CI on windows master. cc/ @nodejs/platform-windows |
Contributor
|
I hate the |
refack
approved these changes
Apr 4, 2017
Contributor
|
LGTM if the CI is green |
jasnell
approved these changes
Apr 4, 2017
Member
|
This LGTM as-is, although I think I'd prefer |
Trott
approved these changes
Apr 4, 2017
Contributor
Author
|
@Trott I agree that would have been better, but for now I think I'm going to land this as-is so that the build on master can be fixed ASAP. I can follow up with another PR to improve the error message. |
The test introduced in a5f91ab accidentally introduced failures on some windows builds. Update the assertion that was causing the failures. PR-URL: nodejs#12212 Ref: nodejs#11689 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
not-an-aardvark
force-pushed
the
fix-windows-cli-test
branch
from
96e8c61 to
9348f31
Compare
Contributor
Author
|
Landed in 9348f31 |
4 tasks
Contributor
Author
|
This fixes a bug that was introduced in a semver-major commit -- it doesn't seem like it makes sense to backport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test introduced in a5f91ab accidentally introduced failures on some windows builds. Update the assertion that was causing the failures.
Ref: #11689
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test