errors: keep error codes in alphabetical order#14242
Closed
starkwang wants to merge 1 commit intonodejs:masterfrom
Closed
errors: keep error codes in alphabetical order#14242starkwang wants to merge 1 commit intonodejs:masterfrom
starkwang wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
errors
vsemozhetbyt
approved these changes
Jul 15, 2017
Contributor
refack
approved these changes
Jul 15, 2017
Contributor
refack
left a comment
refack
left a comment
There was a problem hiding this comment.
That's the only one. Not too bad, I was sure it was a hot mess.
lpinca
approved these changes
Jul 15, 2017
gibfahn
approved these changes
Jul 16, 2017
cjihrig
approved these changes
Jul 16, 2017
tniessen
approved these changes
Jul 16, 2017
jasnell
approved these changes
Jul 17, 2017
Member
|
One failure in CI looks unrelated. |
jasnell
pushed a commit
that referenced
this pull request
Jul 17, 2017
PR-URL: #14242 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in fa73087 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error code
ERR_NO_LONGER_SUPPORTEDin internal/errors is not in alphabetical order. This PR is to fix it.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
errors