[code & learn]test: change style in parallel bad options#14274
Closed
boydfd wants to merge 1 commit intonodejs:masterfrom
Closed
[code & learn]test: change style in parallel bad options#14274boydfd wants to merge 1 commit intonodejs:masterfrom
boydfd wants to merge 1 commit intonodejs:masterfrom
Conversation
Replace string concatenation in test/parallel/test-cli-bad-options.js with template literals.
joyeecheung
added
the
code-and-learn
TimothyGu
added
code-and-learn
gibfahn
approved these changes
Jul 16, 2017
evanlucas
approved these changes
Jul 16, 2017
Contributor
evanlucas
left a comment
evanlucas
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for the contribution!!
cjihrig
approved these changes
Jul 16, 2017
tniessen
approved these changes
Jul 16, 2017
Contributor
refack
approved these changes
Jul 16, 2017
gireeshpunathil
approved these changes
Jul 16, 2017
Member
|
CI was green but I canceled some of the slower ARM hosts to help with our current CI backlog problem. IMO CI can be considered green on this, assuming the one FreeBSD host still running comes back green. |
Member
|
Small change, green CI, 7 approvals, fast-tracking. Landed in 3f7216c Thanks for the contribution! 🎉 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 17, 2017
Replace string concatenation in test/parallel/test-cli-bad-options.js with template literal. Adjust argument layout for readability. PR-URL: nodejs#14274 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
Replace string concatenation in test/parallel/test-cli-bad-options.js with template literal. Adjust argument layout for readability. PR-URL: #14274 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
Replace string concatenation in test/parallel/test-cli-bad-options.js with template literal. Adjust argument layout for readability. PR-URL: #14274 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace string concatenation in test/parallel/test-cli-bad-options.js
with template literals.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)