Closed
Conversation
Add minimal test to confirm that zlib benchmarks run.
Trott
added
benchmark
gibfahn
approved these changes
Aug 11, 2017
cjihrig
approved these changes
Aug 11, 2017
aqrln
approved these changes
Aug 11, 2017
Member
Author
refack
approved these changes
Aug 13, 2017
jasnell
approved these changes
Aug 13, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 14, 2017
Add minimal test to confirm that zlib benchmarks run. PR-URL: nodejs#14763 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Landed in f417add |
Contributor
|
Setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add minimal test to confirm that zlib benchmarks run.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test zlib benchmark