Revert "build: don't add libraries when --enable-static"#14893
Closed
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
Closed
Revert "build: don't add libraries when --enable-static"#14893bnoordhuis wants to merge 1 commit intonodejs:masterfrom
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
Conversation
Reverted for breaking the Windows build with the following error:
LINK : fatal error LNK1181: cannot open input file
'c:\workspace\node-compile-windows\label\win-vs2015\
Release\obj\node\gen\node_javascript.o'
This reverts commit be63c26.
nodejs-github-bot
added
the
build
danbev
approved these changes
Aug 17, 2017
Contributor
danbev
left a comment
danbev
left a comment
There was a problem hiding this comment.
Sorry about this. I'm running the build on windows now and will investigate what the issue is. Thanks
aqrln
approved these changes
Aug 17, 2017
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Aug 17, 2017
Reverted for breaking the Windows build with the following error:
LINK : fatal error LNK1181: cannot open input file
'c:\workspace\node-compile-windows\label\win-vs2015\
Release\obj\node\gen\node_javascript.o'
This reverts commit be63c26.
PR-URL: nodejs#14893
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Member
Author
|
Thanks, landed in aa011a1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverted for breaking the Windows build with the following error:
This reverts commit be63c26.
cc @danbev - since this breaks the CI, I'd like to land this quickly.