tools: make the lint rules depend on tools

[joyeecheung]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

tools

Somewhat related to #16581 (comment) , although this is not related to JS linting. The idea is if we update remark or cpplint.py, then we should re-run the linters so the new changes apply.

[bnoordhuis]

Is there a way to retain the $?? It provides a nice speed-up in the common case when only some files changed.

[joyeecheung]

I have not checked thoroughly but I think the argument in #16581 (comment) applies to the build/include_what_you_use rule of cpplint.py.

[bnoordhuis]

Doesn't really apply, IMO. The build fails if a deleted file is included.

[ljharb]

In the JS scenario, other alternatives include "change what named exports a file has" which would cause linter failures in any unchanged file that imported from it - deleting a file was just one example.

[BridgeAR]

Ping @joyeecheung

[joyeecheung]

@BridgeAR Thanks, I am going to spend some time to work out #16881 (comment) (probably next weekend)

[BridgeAR]

Ping again

[joyeecheung]

I don't think I have seen problems with changes to cpplint.py since #16581 lands. I have not found a way to retain the $ and personally I prefer only running the linters on the files changed. If there is anything wrong, the linter CI will always catch that. I am going to close this now but if anyone still wants to pursue this, feel free to pick it up.