src: use uv_os_getpid() to get process id#17415
Conversation
nodejs-github-bot
added
c++
|
I'd just remove GetProcessId(), it serves no purpose now. (edit: I guess it ensures that you're always dealing with a |
|
I just pushed an updated commit that removes it, and just saw your edit. Should I put it back? |
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
No, I think it's fine. It's 32 bits on all our platforms so it probably makes no practical difference.
|
We should be consistent -- either it stays and the rest of the code base uses it or it is removed and the code base directly calls |
|
Can |
|
It cannot. |
|
But that's probably an academical concern, and arguably a bug in the sandbox, not the application. |
|
TIL. We also wouldn't use the old code as a fallback since |
This commit uses the new uv_os_getpid() method to retrieve the current process id. PR-URL: nodejs#17415 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
This commit uses the new uv_os_getpid() method to retrieve the current process id. PR-URL: #17415 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
This commit uses the new uv_os_getpid() method to retrieve the current process id. PR-URL: #17415 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
|
Should be good to land in the next 6.x and 8.x releases. |
|
@gibfahn FYI this PR depends on libuv 1.18.0. |
|
@richardlau I think we'll be updating libuv in the next version (as long as it doesn't change gcc requirements) |
This commit uses the new uv_os_getpid() method to retrieve the current process id. PR-URL: #17415 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
|
6.x is currently running on libuv 1.16.1, so I'm setting this to |
12 participants
This commit uses the new
uv_os_getpid()method to retrieve thecurrent process id.
I currently left
GetProcessId()in util.cc. Not sure if it should be removed or not.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src