Support options that is classes with props

[mogadanez]

7180597

[brendanashworth]

ref: nodejs/node-v0.x-archive#25454

Could you make the commit log conform to this please? Thanks!

[mscdex]

If we make this change here, should we be changing it everywhere else where we do something similar to maintain consistency?

[brendanashworth]

If we make this change here, should we be changing it everywhere else where we do something similar to maintain consistency?

@jonathanong did some with #635, so I guess so, where it's necessary. I guess someone will want it at some point in time.

Oh - and this also needs a regression test 😄

[jonathanong]

gotta make sure it's not gonna break npm :)

[brendanashworth]

Running the test suite locally reveals that this has bad consequences for tests related to https, I count 17 non-flaky failures.

[vkurchatkin]

@brendanashworth That's because of hasOwnProperty checks probably. We need to get rid of those before

[brendanashworth]

@mogadanez are you able to make the requested changes?

[brendanashworth]

I'm going to close this as some work still needs to be done on this, yet it is still stalled. If someone wants to pick it back up, they're more than welcome to.