doc: update labels info in onboarding-extras.md#19160
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
doc: update labels info in onboarding-extras.md#19160Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Remove information duplicated in onboarding.md. Organize label list for clarity. Remove `deps` label which we don't actually have.
Member
Author
apapirovski
approved these changes
Mar 6, 2018
cjihrig
approved these changes
Mar 6, 2018
jasnell
approved these changes
Mar 6, 2018
Trott
added
the
author ready
Member
Author
|
Lite CI again: https://ci.nodejs.org/job/node-test-pull-request-lite/226/ |
BridgeAR
approved these changes
Mar 6, 2018
lpinca
approved these changes
Mar 7, 2018
Member
Author
|
Landed in 64d5234 |
Trott
added a commit
that referenced
this pull request
Mar 8, 2018
Remove information duplicated in onboarding.md. Organize label list for clarity. Remove `deps` label which we don't actually have. PR-URL: #19160 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 17, 2018
Remove information duplicated in onboarding.md. Organize label list for clarity. Remove `deps` label which we don't actually have. PR-URL: #19160 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
Remove information duplicated in onboarding.md. Organize label list for clarity. Remove `deps` label which we don't actually have. PR-URL: #19160 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Remove information duplicated in onboarding.md. Organize label list for clarity. Remove `deps` label which we don't actually have. PR-URL: nodejs#19160 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Doesn't need to be backported to 8.x or 6.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove information duplicated in onboarding.md. Organize label list for
clarity. Remove
depslabel which we don't actually have.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc