Revert "readline: allow tabs in input"#1961
Closed
Fishrock123 wants to merge 1 commit intonodejs:masterfrom
Closed
Revert "readline: allow tabs in input"#1961Fishrock123 wants to merge 1 commit intonodejs:masterfrom
Fishrock123 wants to merge 1 commit intonodejs:masterfrom
Conversation
This reverts commit 4b3d493.
Fishrock123
added
the
readline
Contributor
Author
|
Also, I will be landing this in next, assuming that LGT-Everyone. |
Contributor
|
LGTM |
Member
|
LGTM2 |
Contributor
Author
|
Thanks, merged in d9e2502 |
Contributor
Author
|
(Will land the original commit back into next momentarily.) |
Contributor
Author
|
Re-landed on next at 2ebc77d |
Member
|
@Fishrock123 Th re-landing of the change appears to have been clobbered at some point in |
This was referenced Jun 22, 2023
This was referenced Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 4b3d493.
Result of some quick discussion with @Trott and @chrisdickinson at nodeconf, it appears this should be semver-major for safety.
cc @rvagg / @brendanashworth, this should land before 2.3.0 releases. (ASAP)