test: add worker prefix to test-message* tests#21512
Closed
targos wants to merge 1 commit intonodejs:masterfrom
Closed
test: add worker prefix to test-message* tests#21512targos wants to merge 1 commit intonodejs:masterfrom
targos wants to merge 1 commit intonodejs:masterfrom
Conversation
lpinca
approved these changes
Jun 24, 2018
jasnell
approved these changes
Jun 24, 2018
cjihrig
approved these changes
Jun 25, 2018
TimothyGu
approved these changes
Jun 25, 2018
trivikr
approved these changes
Jun 25, 2018
trivikr
added
the
author ready
Member
JungMinu
approved these changes
Jun 25, 2018
targos
force-pushed
the
move-worker-tests
branch
from
a07be77 to
d1f6b2f
Compare
hiroppy
approved these changes
Jun 30, 2018
It makes it easier to locate all tests related to the worker subsystem.
targos
force-pushed
the
move-worker-tests
branch
from
d1f6b2f to
bdcb272
Compare
Member
Author
Member
Author
|
Landed in b87b164 |
targos
added a commit
that referenced
this pull request
Jun 30, 2018
It makes it easier to locate all tests related to the worker subsystem. PR-URL: #21512 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
targos
added a commit
that referenced
this pull request
Jul 3, 2018
It makes it easier to locate all tests related to the worker subsystem. PR-URL: #21512 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes it easier to locate all tests related to the worker subsystem.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes