Skip to content

doc: add node-test-commit-custom-suites to docs#21927

Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:internet-tests
Closed

doc: add node-test-commit-custom-suites to docs#21927
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:internet-tests

Conversation

@Trott
Copy link
Member

@Trott Trott commented Jul 21, 2018

Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.

Refs: #21909 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

/ping @lance @maclover7

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 21, 2018

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/330/pipeline

@Trott Trott mentioned this pull request Jul 21, 2018
Closed
2 tasks
@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. meta Issues and PRs related to the general management of the project. labels Jul 21, 2018
lance
lance approved these changes Jul 21, 2018
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott thanks!

richardlau
richardlau reviewed Jul 21, 2018
View reviewed changes
COLLABORATOR_GUIDE.md Outdated
Copy link
Member

@richardlau richardlau Jul 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it is true that the default CI_JS_SUITES parameters to the job run internet the job is intended to run any test(suite) with custom arguments (I think you could even simulate the stress job by passing --repeat to TEST_ARGS).

Copy link
Member Author

@Trott Trott Jul 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to provide the minimum information to be useful. (I'd like to see pummel added FWIW.) If you have some alternate or additional text, do feel free to add it!

@maclover7 maclover7 mentioned this pull request Jul 22, 2018
Closed
3 tasks
maclover7
maclover7 reviewed Jul 22, 2018
View reviewed changes
COLLABORATOR_GUIDE.md Outdated
Copy link
Contributor

@maclover7 maclover7 Jul 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly... how about:

node-test-commit-custom-suites runs tests in user-specified directories with parameters provided by the user as well. Currently used on all node-test-commit jobs to run the default test suite with the --worker flag.

Copy link
Member Author

@Trott Trott Jul 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maclover7 Updated. PTAL

@Trott
doc: add node-test-commit-custom-suites to docs
1a65fbc 
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.

Refs: nodejs#21909 (comment)
maclover7
maclover7 approved these changes Jul 23, 2018
View reviewed changes
Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Trott
Copy link
Member Author

Trott commented Jul 23, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/342/

Trott added a commit to Trott/io.js that referenced this pull request Jul 24, 2018
@Trott
doc: add node-test-commit-custom-suites to docs
f5a2167 
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.

Refs: nodejs#21909 (comment)

PR-URL: nodejs#21927
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jul 24, 2018

Landed in f5a2167

@Trott Trott closed this Jul 24, 2018
targos pushed a commit that referenced this pull request Jul 26, 2018
@Trott @targos
doc: add node-test-commit-custom-suites to docs
96bb605 
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.

Refs: #21909 (comment)

PR-URL: #21927
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the internet-tests branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

@trivikr trivikr trivikr approved these changes

+2 more reviewers

@lance lance lance approved these changes

@maclover7 maclover7 maclover7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott @nodejs-github-bot @lance @maclover7 @richardlau @trivikr @vsemozhetbyt