uv: move process.binding('uv') to internalBinding

[jasnell]

Move process.binding('uv') to internalBinding('uv')

/cc #22160

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[nodejs-github-bot]

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/447/pipeline

[jasnell]

CI: https://ci.nodejs.org/job/node-test-pull-request/16233/

[maclover7]

CITGM (sqlite3 and winston have been flaky as of late): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1490/

[maclover7]

CITGM results look okay, LGTM if CI passes

[jasnell]

New CI after rebase: https://ci.nodejs.org/job/node-test-pull-request/16307/

[jasnell]

Redo on the custom-suites job: https://ci.nodejs.org/job/node-test-commit-custom-suites/586/

[jasnell]

Landed in c7962dc

[maclover7]

Hmm, looks like the CITGM results actually show a regression in the test suite for yargs@12.0.1 (cc @bcoe):

execa/lib/errname: unable to establish process.binding('uv') Error: No such module: uv
     at process.binding (internal/bootstrap/loaders.js:81:36)
     at Object.<anonymous> (/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1404-64/citgm_tmp/5361800e-a5e4-4803-9e84-d666d26c0fce/yargs/node_modules/nyc/node_modules/execa/lib/errname.js:12:15)
     at Module._compile (internal/modules/cjs/loader.js:689:30)
     at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
     at Module.load (internal/modules/cjs/loader.js:599:32)
     at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
     at Function.Module._load (internal/modules/cjs/loader.js:530:3)
     at Module.require (internal/modules/cjs/loader.js:637:17)
     at require (internal/modules/cjs/helpers.js:20:18)
     at Object.<anonymous> (/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1404-64/citgm_tmp/5361800e-a5e4-4803-9e84-d666d26c0fce/yargs/node_modules/nyc/node_modules/execa/index.js:11:17)

[maclover7]

Relevant PR from @addaleax to the yargs submodule that's actually causing the error: sindresorhus/execa#125

[addaleax]

@maclover7 That PR should have prevented exactly this – I think this might just be something that requires dependency updates to nyc (and/or yargs)?

Also, I think this is a case where a runtime deprecation should really have been considered before landing the PR.

[jasnell]

Sigh. We can add back the process.binding export for now alongside the internalBinding.

[jasnell]

Will get a PR opened

[addaleax]

@jasnell Maybe we can wrap process.binding so that it forwards but warns on a specified set of bindings? Something like:

const forward = ['uv', ...];
const originalProcessBinding = process.binding;
process.binding = function(id) {
  if (forward.includes(id)) {
    process.emitWarning(...);
    return internalBinding(id);
  } 
  return originalProcessBinding(id);
};

That might transitioning a bit smoother in general…

[jasnell]

That's a better approach than what I was thinking @addaleax :-) Will go that route

[jasnell]

See #22269