js_stream: move process.binding('js_stream') to internalBinding

[antsmartian]

Migration from process.binding to internalBinding (see : #22160)

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[jasnell]

LGTM with good CITGM run

[maclover7]

CI: https://ci.nodejs.org/job/node-test-pull-request/16344/
(will start a CITGM run after the current job is finished)

[maclover7]

CITGM: https://ci.nodejs.org/job/citgm-smoker/1501

[jdalton]

Holding removals until migration is ironed out

[jasnell]

@antsmartian ... when you get a moment, can you rebase this from master then apply the following patch that will be required for this to proceed:

Author: James M Snell <jasnell@gmail.com>
Date:   Tue Aug 14 19:36:25 2018 -0700

    [Squash] add `process.binding('js_stream')` to fallthrough whitelist

diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
index 08daeb1915..ffae6e4cd9 100644
--- a/lib/internal/bootstrap/node.js
+++ b/lib/internal/bootstrap/node.js
@@ -327,7 +327,7 @@
     // that are whitelisted for access via process.binding()... this is used
     // to provide a transition path for modules that are being moved over to
     // internalBinding.
-    const internalBindingWhitelist = new SafeSet(['uv']);
+    const internalBindingWhitelist = new SafeSet(['uv', 'js_stream']);
     process.binding = function binding(name) {
       return internalBindingWhitelist.has(name) ?
         internalBinding(name) :
diff --git a/test/parallel/test-process-binding-internalbinding-whitelist.js b/test/parallel/test-process-binding-internalbinding-whitelist.js
index ece967a0b7..cc0119917d 100644
--- a/test/parallel/test-process-binding-internalbinding-whitelist.js
+++ b/test/parallel/test-process-binding-internalbinding-whitelist.js
@@ -7,3 +7,4 @@ const assert = require('assert');
 // Assert that whitelisted internalBinding modules are accessible via
 // process.binding().
 assert(process.binding('uv'));
+assert(process.binding('js_stream'));

[antsmartian]

@jasnell Now it should be good to go.. Thanks..

[jasnell]

@antsmartian ... this will need another rebase now that some of the other conversions to internalBinding have landed.

[antsmartian]

@jasnell Taken care, guess it should be all good now.

[jasnell]

New CI: https://ci.nodejs.org/job/node-test-pull-request/16617/

[jasnell]

Just noticed that this used a merge commit and it's failing CI because of it. Can you squash this down to a single commit and use rebase to catch it up to master. We don't use merge commits at all.

[antsmartian]

@jasnell Sorry, didn't notice that. Now its all green.. thanks for your support.

[jasnell]

CI: https://ci.nodejs.org/job/node-test-pull-request/16645/

[jasnell]

@antsmartian ... unfortunately this will need another rebase

[antsmartian]

@jasnell Done.

[addaleax]

And, yet another rebase is necessary … sorry :(

[antsmartian]

@addaleax No worries, I have an another PR which also needs rebase, will do it tonight and ping you.

[antsmartian]

@addaleax Rebased it, now it should be good I guess.. cc @jasnell

[lundibundi]

There is one more usage in lib/internal/wrap_js_stream.js, do we not want to change that as well?

[BridgeAR]

LGTM with @lundibundi s comment addressed.

[antsmartian]

Yet again conflicts, let me rebase it tonight.. sorry folks..

[antsmartian]

Ping @nodejs/collaborators . Can we merge this please, before I get another conflict :) Thanks!

Edit: Looks like I can't ping teams. So pinging few people : @BridgeAR @addaleax @jasnell @trivikr

[trivikr]

New CI: https://ci.nodejs.org/job/node-test-pull-request/17215/

[addaleax]

New CI: https://ci.nodejs.org/job/node-test-pull-request/17249/

[addaleax]

Landed in dcc0c2c

[antsmartian]

@addaleax Thanks !