build: touch tools/doc/node_modules after run#22350
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
Closed
build: touch tools/doc/node_modules after run#22350danbev wants to merge 1 commit intonodejs:masterfrom
danbev wants to merge 1 commit intonodejs:masterfrom
Conversation
Collaborator
|
@danbev sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
the
build
richardlau
approved these changes
Aug 16, 2018
Contributor
Author
jasnell
approved these changes
Aug 16, 2018
Contributor
|
/CC @nodejs/build-files |
Contributor
|
Testing with rebase (Ref: nodejs/build#1442 (comment)): |
BridgeAR
added
the
author ready
joyeecheung
approved these changes
Aug 17, 2018
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
LGTM, but I wonder why the time stamp is not updated after npm install?
Currently, tools/doc/node_modules is not touched after running npm install resulting in npm install being run every time. I missed this while testing commit 88bff82 ("build: make tools/doc/node_modules non-phony").
Trott
force-pushed
the
build_touch_node_modules
branch
from
020bb18 to
8833d8f
Compare
Member
|
Rebased (to get the recently-committed fix for a CI gotcha), force-pushed, new CI: https://ci.nodejs.org/job/node-test-pull-request/16557/ |
Member
|
Landed in 104492b 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Aug 20, 2018
Currently, tools/doc/node_modules is not touched after running npm install resulting in npm install being run every time. I missed this while testing commit 88bff82 ("build: make tools/doc/node_modules non-phony"). PR-URL: nodejs#22350 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 21, 2018
Currently, tools/doc/node_modules is not touched after running npm install resulting in npm install being run every time. I missed this while testing commit 88bff82 ("build: make tools/doc/node_modules non-phony"). PR-URL: #22350 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Currently, tools/doc/node_modules is not touched after running npm install resulting in npm install being run every time. I missed this while testing commit 88bff82 ("build: make tools/doc/node_modules non-phony"). PR-URL: #22350 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, tools/doc/node_modules is not touched after running npm
install resulting in npm install being run every time. I missed this
while testing commit 88bff82 ("build:
make tools/doc/node_modules non-phony").
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes