crypto: remove unnecessary usage of goto#23018
Closed
tniessen wants to merge 1 commit intonodejs:masterfrom
Closed
crypto: remove unnecessary usage of goto#23018tniessen wants to merge 1 commit intonodejs:masterfrom
tniessen wants to merge 1 commit intonodejs:masterfrom
Conversation
The control flow can easily be refactored to use break instead of goto.
nodejs-github-bot
added
c++
addaleax
approved these changes
Sep 22, 2018
targos
approved these changes
Sep 22, 2018
bnoordhuis
approved these changes
Sep 22, 2018
cjihrig
approved these changes
Sep 22, 2018
jasnell
approved these changes
Sep 22, 2018
Member
Author
lpinca
approved these changes
Sep 22, 2018
BridgeAR
approved these changes
Sep 23, 2018
BridgeAR
added
the
author ready
Contributor
|
Landed in 3eb2adb. |
danbev
pushed a commit
that referenced
this pull request
Sep 25, 2018
The control flow can easily be refactored to use break instead of goto. PR-URL: #23018 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Sep 25, 2018
The control flow can easily be refactored to use break instead of goto. PR-URL: #23018 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Oct 10, 2018
tniessen
removed
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The control flow can easily be refactored to use
breakinstead ofgoto. The second occurrence is unnecessary as well and can be removed.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes