test: check codes of thrown errors#23519
Closed
truonghnancy wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
jasnell
added
code-and-learn
targos
added
code-and-learn
jasnell
approved these changes
Oct 12, 2018
trivikr
reviewed
Oct 13, 2018
test/parallel/test-buffer-alloc.js
Outdated
Member
There was a problem hiding this comment.
The object can be moved to a function, for example:
const getRangeError = (min, max, received) => ({
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError [ERR_OUT_OF_RANGE]',
message: `The value of "offset" is out of range. It must be >= ${min} ` +
'and <= ${max}. Received ${received}'
});
And reused across the file
Member
|
Uh … @Trott what do we do here? I think this conflicts quite a bit with your PR in https://github.com/nodejs/node/pull/23645… |
addaleax
approved these changes
Oct 16, 2018
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Looks good!
This needs a rebase, unfortunately, and I don’t know how tricky that gets…
Trott
force-pushed
the
check-error-code-in-tests
branch
from
be1f9c6 to
f1e4160
Compare
Member
|
I rebased and force pushed to resolve the merge conflict. New CI: https://ci.nodejs.org/job/node-test-pull-request/17923/ |
BridgeAR
approved these changes
Oct 17, 2018
BridgeAR
added
the
author ready
gdams
approved these changes
Oct 17, 2018
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 18, 2018
PR-URL: nodejs#23519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: George Adams <george.adams@uk.ibm.com>
Member
|
Landed in c208135 |
addaleax
pushed a commit
that referenced
this pull request
Oct 20, 2018
PR-URL: #23519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: George Adams <george.adams@uk.ibm.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 21, 2018
PR-URL: #23519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: George Adams <george.adams@uk.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
PR-URL: #23519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: George Adams <george.adams@uk.ibm.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #23519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: George Adams <george.adams@uk.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
PR-URL: #23519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: George Adams <george.adams@uk.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes