build: add -Werror=undefined-inline to clang builds

[refack]

Hopefully the start of a trend to move more cases to -Werror

Refs: #23954
Refs: #23910
Refs: #23880

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[nodejs-github-bot]

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1411/pipeline

[refack]

CI: https://ci.nodejs.org/job/node-test-pull-request/18212/

[targos]

I guess we should block on #23954?

[refack]

Fails as expected on macOS (with clang)

15:06:27   /usr/local/bin/ccache c++ -o /Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1011/out/Release/obj.target/node_lib/src/inspector/worker_inspector.o ../src/inspector/worker_inspector.cc '-D_DARWIN_USE_64_BIT_INODE=1' '-DNODE_ARCH="x64"' '-DNODE_WANT_INTERNALS=1' '-DV8_DEPRECATION_WARNINGS=1' '-DNODE_OPENSSL_SYSTEM_CERT_PATH=""' '-DHAVE_INSPECTOR=1' '-DHAVE_DTRACE=1' '-D__POSIX__' '-DNODE_USE_V8_PLATFORM=1' '-DNODE_HAVE_I18N_SUPPORT=1' '-DNODE_HAVE_SMALL_ICU=1' '-DNODE_PLATFORM="darwin"' '-DHAVE_OPENSSL=1' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' '-DHTTP_PARSER_STRICT=0' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-DNGHTTP2_STATICLIB' -I../src -I/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1011/out/Release/obj/gen -I/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1011/out/Release/obj/gen/include -I/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1011/out/Release/obj/gen/src -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common -I../deps/zlib -I../deps/http_parser -I../deps/cares/include -I../deps/uv/include -I../deps/nghttp2/lib/includes -I../deps/openssl/openssl/include  -Os -gdwarf-2 -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -Wall -Wendif-labels -W -Wno-unused-parameter -Werror=undefined-inline -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1011/out/Release/.deps//Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1011/out/Release/obj.target/node_lib/src/inspector/worker_inspector.o.d.raw   -c
15:06:28 In file included from ../src/inspector/worker_inspector.cc:3:
15:06:28 In file included from ../src/inspector/main_thread_interface.h:8:
15:06:28 In file included from ../src/env.h:27:
15:06:28 In file included from ../src/aliased_buffer.h:7:
15:06:28 ../src/util.h:65:11: error: inline function 'node::Calloc<unsigned char>' is not defined [-Werror,-Wundefined-inline]
15:06:28 inline T* Calloc(size_t n);
15:06:28           ^
15:06:28 ../src/aliased_buffer.h:41:15: note: used here
15:06:28     buffer_ = Calloc<NativeT>(count);
15:06:28               ^
15:06:28 1 error generated.
15:06:28 make[2]: *** [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1011/out/Release/obj.target/node_lib/src/inspector/worker_inspector.o] Error 1

Waiting for #23954

[targos]

Why didn't it fail on FreeBSD?

[refack]

Why didn't it fail on FreeBSD?

Probably because the clang GYP variable is not set. I'll fix that in a separate PR.

[refack]

#23954 landed so unblocked.
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18236/

[bnoordhuis]

@refack Did you forget to rebase? It's still failing with the same build error.

[refack]

Did you forget to rebase?

pushed without force, and didn't look at results...

new resume: https://ci.nodejs.org/job/node-test-pull-request/18260/

[refack]

Two more hours, so lets CI again: https://ci.nodejs.org/job/node-test-pull-request/18262/

[MylesBorins]

opted to land on 10.x but not 8.x

[barracuda156]

Not only it breaks the build with GCC, but it gets pulled out from somewhere even after being patched out.