test: replaced anonymous functions with closuers#24442
Closed
rkp1146 wants to merge 1 commit intonodejs:masterfrom
Closed
test: replaced anonymous functions with closuers#24442rkp1146 wants to merge 1 commit intonodejs:masterfrom
rkp1146 wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
|
I suppose it was closed by mistake? |
targos
reviewed
Nov 17, 2018
Member
targos
left a comment
There was a problem hiding this comment.
Changes LGTM.
Commit message should look like: test: replace anonymous functions with arrow functions
trivikr
approved these changes
Nov 18, 2018
Member
|
@rkp1146 - your email is not associated with your GitHub account while you pushed the change. |
gireeshpunathil
approved these changes
Nov 18, 2018
cjihrig
approved these changes
Nov 18, 2018
jasnell
approved these changes
Nov 19, 2018
sagirk
approved these changes
Nov 19, 2018
Member
|
fast-track? 👍 |
Member
Member
|
Resume build CI: https://ci.nodejs.org/job/node-test-commit/23491/ |
Member
|
failure in windows-fanned seems unrelated. Resume CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/22620/ |
Member
|
the single failure in windows-fanned is unrelated; landing. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes