test: fix the arguments order in assert.strictEqual#24620
test: fix the arguments order in assert.strictEqual#24620pastak wants to merge 1 commit intonodejs:masterfrom
Conversation
addaleax
added
the
code-and-learn
|
fast-track? pls 👍 |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19003/ |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19016/ |
|
single failure in arm-fanned is: |
|
@Trott - should I get this test under |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19023/ |
Probably a good idea if we've seen it more than once (which we have). I mean, unless there's an obvious fix (which there probably isn't). Errr...that was a long-winded way of saying, "Yes, sounds like a good idea to me." |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19026/ |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19034/ |
This is a known failure so mark it such, so that CI is green / amber while the issue is being progressed. PR-URL: nodejs#24712 Refs: nodejs#24620 Refs: nodejs#24120 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19047/ |
|
Now that the super-problematic test is marked as flaky, let's do a re-run from scratch (so that we get that flaky status marking in the CI for this) and hopefully this passes no problem: https://ci.nodejs.org/job/node-test-pull-request/19055/ |
|
Landed in 97fedef. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
PR-URL: nodejs#24620 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
PR-URL: #24620 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
This is a known failure so mark it such, so that CI is green / amber while the issue is being progressed. PR-URL: nodejs#24712 Refs: nodejs#24620 Refs: nodejs#24120 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: nodejs#24620 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
PR-URL: #24620 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
PR-URL: #24620 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
10 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes