test: mark test-child-process-execsync flaky on AIX#25031
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: mark test-child-process-execsync flaky on AIX#25031Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Trott
added
child_process
Member
Author
gireeshpunathil
approved these changes
Dec 14, 2018
Trott
added
the
author ready
cjihrig
approved these changes
Dec 14, 2018
Member
Author
|
Windows CI Rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/23280/ ✔️ |
Member
Author
|
CI is good but this needs one more Collaborator approval to fast-track. |
bmeck
approved these changes
Dec 14, 2018
richardlau
approved these changes
Dec 14, 2018
Member
Author
|
Landed in d0c240f |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 14, 2018
Refs: nodejs#24921 PR-URL: nodejs#25031 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Refs: nodejs#24921 PR-URL: nodejs#25031 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributors, please 👍 here to fast-track.
Refs: #24921
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes