test: mark test-child-process-exit-code flaky#25050
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: mark test-child-process-exit-code flaky#25050Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Trott
added
child_process
Member
Author
joyeecheung
approved these changes
Dec 14, 2018
cjihrig
approved these changes
Dec 14, 2018
gireeshpunathil
approved these changes
Dec 15, 2018
Member
Author
|
Windows re-run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/23305/ ✔️ |
Member
Author
|
Landed in bcf3901 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 15, 2018
Refs: # nodejs#25033 PR-URL: nodejs#25050 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
sagitsofan
pushed a commit
to sagitsofan/node
that referenced
this pull request
Dec 24, 2018
Refs: # nodejs#25033 PR-URL: nodejs#25050 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Refs: # nodejs#25033 PR-URL: nodejs#25050 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collaborators 👍 here to fast-track.
Refs: # #25033
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes