test: changed function to arrow function#25441
Closed
yathamravali wants to merge 2 commits intonodejs:masterfrom
Closed
test: changed function to arrow function#25441yathamravali wants to merge 2 commits intonodejs:masterfrom
yathamravali wants to merge 2 commits intonodejs:masterfrom
Conversation
addaleax
approved these changes
Jan 12, 2019
Member
gireeshpunathil
approved these changes
Jan 13, 2019
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-commit/25009/ |
cjihrig
approved these changes
Jan 14, 2019
jasnell
approved these changes
Jan 14, 2019
Member
Contributor
|
Re-run of failing node-test-commit-arm |
This was referenced Jan 16, 2019
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-commit/25182/ |
gireeshpunathil
added
the
author ready
Member
|
landed as 27871c3 , thanks! |
gireeshpunathil
pushed a commit
that referenced
this pull request
Jan 21, 2019
PR-URL: #25441 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gireeshpunathil
removed
the
author ready
addaleax
pushed a commit
that referenced
this pull request
Jan 23, 2019
PR-URL: #25441 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 29, 2019
PR-URL: #25441 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
PR-URL: #25441 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
PR-URL: #25441 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first pr.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes