Skip to content

src: pass through Maybes from bootstrapper functions#25620

Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:bootstrapper-maybe
Closed

src: pass through Maybes from bootstrapper functions#25620
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:bootstrapper-maybe

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Jan 21, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 21, 2019

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2327/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 21, 2019
@addaleax
Copy link
Member Author

addaleax commented Jan 23, 2019

I’m closing this as this is essentially covered by @joyeecheung’s #25667

@addaleax addaleax closed this Jan 23, 2019
@addaleax addaleax deleted the bootstrapper-maybe branch January 23, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@addaleax @nodejs-github-bot