tools: make test.py Queue part Python 3 compatible#25701
Closed
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Closed
tools: make test.py Queue part Python 3 compatible#25701gengjiawen wants to merge 1 commit intonodejs:masterfrom
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
test
cclauss
approved these changes
Jan 25, 2019
addaleax
approved these changes
Jan 25, 2019
Member
Member
|
This patch failed the python linter… /cc @nodejs/python |
Contributor
|
Just reverse the try except and change the exception to ImportError. |
thefourtheye
approved these changes
Jan 28, 2019
Contributor
thefourtheye
left a comment
thefourtheye
left a comment
There was a problem hiding this comment.
LGTM with @cclauss's suggested change.
Member
Author
|
I can change it. But the root cause is the lint bug. |
Contributor
|
The linter is not wrong ModuleNotFoundError does not exist in Python < 3.6 thus it is an undefined name. Please replace it with ImportError. |
Member
Author
|
I see, thanks for the info. |
cclauss
reviewed
Jan 28, 2019
tools/test.py
Outdated
Contributor
There was a problem hiding this comment.
try:
from queue import Queue, Empty # Python 3
except ImportError:
from Queue import Queue, Empty # Python 2
Contributor
There was a problem hiding this comment.
Member
Author
|
I will push again when I got home :) |
Signed-off-by: gengjiawen <technicalcute@gmail.com>
gengjiawen
force-pushed
the
feature/test_python3
branch
from
8dc295a to
d30502d
Compare
Contributor
refack
approved these changes
Jan 28, 2019
Member
|
Landed in 08100bf |
addaleax
pushed a commit
that referenced
this pull request
Jan 28, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25701 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
refack
added
the
python
addaleax
pushed a commit
that referenced
this pull request
Jan 28, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25701 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 29, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25701 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25701 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25701 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passescc @nodejs/python @cclauss