process: delay and simplify the setup of async hooks trace events by joyeecheung · Pull Request #26062 · nodejs/node

joyeecheung · 2019-02-12T22:55:48Z

src: move async hooks trace events setup to pre_execution.js

Reasons:

Moves more environment-dependent setup out of bootstrap/node.js
No async operations should be done before the call to
the setup functions in pre_execution.js so no async hooks should be
triggered before that. Therefore it is safe to delay the setup
until then.

process: simplify the setup of async hooks trace events

Remove trace_category_state from Environment - since this is
only accessed in the bootstrap process and later in the
trace category update handler, we could just pass the initial
values into JS land via the trace_events binding, and pass
the dynamic values directly to the handler later, instead of
accessing them out-of-band via the AliasedBuffer.
Instead of creating the hooks directly in
trace_events_async_hooks.js, export the hook factory and
create the hooks in trace category state toggle.

test: add test for node.async_hooks tracing in workers

test: add test for dynamically enabling node.async_hooks tracing

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2019-02-12T22:55:50Z

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2583/pipeline

joyeecheung · 2019-02-12T23:18:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/20747/

jasnell · 2019-02-18T16:18:02Z

Trace events are not available in worker threads.

I think I missed something. Why is this? They should be available.

addaleax · 2019-02-18T16:27:10Z

@jasnell Right – it’s just the JS module that’s not accessible… Is there a test for this code? I think that should have failed in CI if this PR breaks trace_events + Workers, but it looks like everything passed here

joyeecheung · 2019-02-19T07:56:50Z

@addaleax I don't think there is a test, it could be added but I don't think the dynamic switch can be tested in workers since dynamically enabling the category requires the trace_events module. I could add the preparation code to the worker bootstrap script though, at least that allows us to test the initial enabling of the events.

Reasons: - Moves more environment-dependent setup out of bootstrap/node.js - No async operations should be done before the call to the setup functions in pre_execution.js so no async hooks should be triggered before that. Therefore it is safe to delay the setup until then.

- Remove `trace_category_state` from `Environment` - since this is only accessed in the bootstrap process and later in the trace category update handler, we could just pass the initial values into JS land via the trace_events binding, and pass the dynamic values directly to the handler later, instead of accessing them out-of-band via the AliasedBuffer. - Instead of creating the hooks directly in `trace_events_async_hooks.js`, export the hook factory and create the hooks in trace category state toggle.

joyeecheung · 2019-02-19T10:12:47Z

I added the setup to the worker bootstrap, fixed a bug in the C++ part (when the category is enabled the value is 0x7, not 1, so we should test for != 0 instead), and added two tests. @jasnell @addaleax PTAL.

CI: https://ci.nodejs.org/job/node-test-pull-request/20879/

joyeecheung · 2019-02-20T15:40:10Z

Added hasTracing guards in tests. Not sure why the CI complained about missing dynamically linked deps and libc, let's see what happens in a new CI: https://ci.nodejs.org/job/node-test-pull-request/20907/

test/parallel/test-trace-events-async-hooks-dynamic.js

test/parallel/test-trace-events-async-hooks-worker.js

joyeecheung · 2019-02-20T17:24:27Z

@richardlau Thanks! I've updated the env passed to spawnSync. CI: https://ci.nodejs.org/job/node-test-pull-request/20913/

joyeecheung · 2019-02-21T02:58:31Z

Landed in dec3dad...85df2c4

Reasons: - Moves more environment-dependent setup out of bootstrap/node.js - No async operations should be done before the call to the setup functions in pre_execution.js so no async hooks should be triggered before that. Therefore it is safe to delay the setup until then. PR-URL: #26062 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

- Remove `trace_category_state` from `Environment` - since this is only accessed in the bootstrap process and later in the trace category update handler, we could just pass the initial values into JS land via the trace_events binding, and pass the dynamic values directly to the handler later, instead of accessing them out-of-band via the AliasedBuffer. - Instead of creating the hooks directly in `trace_events_async_hooks.js`, export the hook factory and create the hooks in trace category state toggle. PR-URL: #26062 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #26062 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Reasons: - Moves more environment-dependent setup out of bootstrap/node.js - No async operations should be done before the call to the setup functions in pre_execution.js so no async hooks should be triggered before that. Therefore it is safe to delay the setup until then. PR-URL: #26062 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

- Remove `trace_category_state` from `Environment` - since this is only accessed in the bootstrap process and later in the trace category update handler, we could just pass the initial values into JS land via the trace_events binding, and pass the dynamic values directly to the handler later, instead of accessing them out-of-band via the AliasedBuffer. - Instead of creating the hooks directly in `trace_events_async_hooks.js`, export the hook factory and create the hooks in trace category state toggle. PR-URL: #26062 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #26062 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Reasons: - Moves more environment-dependent setup out of bootstrap/node.js - No async operations should be done before the call to the setup functions in pre_execution.js so no async hooks should be triggered before that. Therefore it is safe to delay the setup until then. PR-URL: #26062 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

- Remove `trace_category_state` from `Environment` - since this is only accessed in the bootstrap process and later in the trace category update handler, we could just pass the initial values into JS land via the trace_events binding, and pass the dynamic values directly to the handler later, instead of accessing them out-of-band via the AliasedBuffer. - Instead of creating the hooks directly in `trace_events_async_hooks.js`, export the hook factory and create the hooks in trace category state toggle. PR-URL: #26062 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #26062 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Feb 12, 2019

joyeecheung requested a review from jasnell February 12, 2019 23:18

addaleax approved these changes Feb 15, 2019

View reviewed changes

joyeecheung added 2 commits February 19, 2019 18:03

joyeecheung force-pushed the simplify-trace-async branch from 8018819 to 38c772b Compare February 19, 2019 10:08

richardlau reviewed Feb 20, 2019

View reviewed changes

test/parallel/test-trace-events-async-hooks-dynamic.js Outdated Show resolved Hide resolved

test/parallel/test-trace-events-async-hooks-worker.js Outdated Show resolved Hide resolved

joyeecheung added 2 commits February 21, 2019 00:45

test: add test for node.async_hooks tracing in workers

2472b05

test: add test for dynamically enabling node.async_hooks tracing

400c370

joyeecheung force-pushed the simplify-trace-async branch from 73eaecb to 400c370 Compare February 20, 2019 16:46

richardlau approved these changes Feb 20, 2019

View reviewed changes

jasnell approved these changes Feb 21, 2019

View reviewed changes

joyeecheung added async_hooks Issues and PRs related to the async hooks subsystem. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. labels Feb 21, 2019

joyeecheung closed this Feb 21, 2019

joyeecheung added a commit that referenced this pull request Feb 21, 2019

test: add test for node.async_hooks tracing in workers

908e114

PR-URL: #26062 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax pushed a commit that referenced this pull request Feb 21, 2019

test: add test for node.async_hooks tracing in workers

317b86c

PR-URL: #26062 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR mentioned this pull request Feb 26, 2019

v11.11.0 proposal #26322

Merged

rvagg pushed a commit that referenced this pull request Feb 28, 2019

test: add test for node.async_hooks tracing in workers

dcbd907

PR-URL: #26062 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

joyeecheung mentioned this pull request Mar 12, 2019

process: set the trace category update handler during bootstrap #26605

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

process: delay and simplify the setup of async hooks trace events#26062

process: delay and simplify the setup of async hooks trace events#26062
joyeecheung wants to merge 4 commits intonodejs:masterfrom
joyeecheung:simplify-trace-async

joyeecheung commented Feb 12, 2019 •

edited

Loading

Uh oh!

nodejs-github-bot commented Feb 12, 2019

Uh oh!

joyeecheung commented Feb 12, 2019

Uh oh!

jasnell commented Feb 18, 2019

Uh oh!

addaleax commented Feb 18, 2019

Uh oh!

joyeecheung commented Feb 19, 2019

Uh oh!

joyeecheung commented Feb 19, 2019

Uh oh!

joyeecheung commented Feb 20, 2019

Uh oh!

Uh oh!

Uh oh!

joyeecheung commented Feb 20, 2019

Uh oh!

joyeecheung commented Feb 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

joyeecheung commented Feb 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

src: move async hooks trace events setup to pre_execution.js

process: simplify the setup of async hooks trace events

test: add test for node.async_hooks tracing in workers

test: add test for dynamically enabling node.async_hooks tracing

Checklist

Uh oh!

nodejs-github-bot commented Feb 12, 2019

Uh oh!

joyeecheung commented Feb 12, 2019

Uh oh!

jasnell commented Feb 18, 2019

Uh oh!

addaleax commented Feb 18, 2019

Uh oh!

joyeecheung commented Feb 19, 2019

Uh oh!

joyeecheung commented Feb 19, 2019

Uh oh!

joyeecheung commented Feb 20, 2019

Uh oh!

Uh oh!

Uh oh!

joyeecheung commented Feb 20, 2019

Uh oh!

joyeecheung commented Feb 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

joyeecheung commented Feb 12, 2019 •

edited

Loading