src: simplify InspectorConsoleCall#26168
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Instead of a JS object, set the is-in-console-call flag as a boolean in C++.
nodejs-github-bot
added
c++
joyeecheung
approved these changes
Feb 17, 2019
devsnek
approved these changes
Feb 17, 2019
jasnell
approved these changes
Feb 18, 2019
eugeneo
approved these changes
Feb 19, 2019
Member
Author
addaleax
added
the
author ready
Member
Author
|
Landed in a34a84d |
addaleax
added a commit
that referenced
this pull request
Feb 20, 2019
Instead of a JS object, set the is-in-console-call flag as a boolean in C++. PR-URL: #26168 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
addaleax
added a commit
that referenced
this pull request
Feb 21, 2019
Instead of a JS object, set the is-in-console-call flag as a boolean in C++. PR-URL: #26168 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Instead of a JS object, set the is-in-console-call flag as a boolean in C++. PR-URL: #26168 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of a JS object, set the is-in-console-call flag as
a boolean in C++.
(Based on @joyeecheung’s suggestion in #26113)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes