Merged
Conversation
Collaborator
nodejs-github-bot
added
the
lib / src
refack
approved these changes
Mar 31, 2019
bnoordhuis
reviewed
Apr 1, 2019
src/node_report.cc
Outdated
Member
There was a problem hiding this comment.
This might overflow when tv_sec is a 32 bits long.
(I kind of regret that we didn't use int64_t for uv_timeval_t.tv_sec...)
Contributor
There was a problem hiding this comment.
Maybe there's still time to change uv_gettimeofday to uint64_t uv_gettimeofday() (or unsigned long long int) and always return microseconds? Seems like uv_timeval_t is a little "legacy" for this API
Contributor
Author
There was a problem hiding this comment.
That's not a bad idea. Since uv_gettimeofday() hasn't been released yet, there is time.
Contributor
Author
|
@bnoordhuis I think I've addressed your nits with the new libuv release. |
Collaborator
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/22640/ EDIT(cjihrig): CI was green. |
dumpEventTimeStamp was not implemented on Windows, and did not include any error checking. This commit adds Windows support and error checking. PR-URL: nodejs#27029 Reviewed-By: Refael Ackermann <refack@gmail.com>
Use uv_gettimeofday() in GetCurrentTimeInMicroseconds() to remove the need for #ifdef logic. PR-URL: nodejs#27029 Reviewed-By: Refael Ackermann <refack@gmail.com>
Contributor
Author
|
Landed in 90cf2d5...8e1e994. |
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Labeled as a WIP until the next libuv update (ignore the first commit here).
The next version of libuv will provide
uv_gettimeofday()as a cross platform alternative togettimeofday().Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes