errors: add more information in case of invalid callbacks#27048
Closed
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Closed
errors: add more information in case of invalid callbacks#27048BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Conversation
This adds the actual callback that is passed through to the error message in case an ERR_INVALID_CALLBACK error is thrown.
Collaborator
nodejs-github-bot
added
the
lib / src
lpinca
approved these changes
Apr 2, 2019
BridgeAR
added
the
author ready
Collaborator
ZYSzys
approved these changes
Apr 3, 2019
Member
Author
|
Landed in 3b04496 🎉 |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 4, 2019
This adds the actual callback that is passed through to the error message in case an ERR_INVALID_CALLBACK error is thrown. PR-URL: nodejs#27048 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the actual callback that is passed through to the error
message in case an ERR_INVALID_CALLBACK error is thrown.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes