src: unify crypto constant setup

[sam-github]

DefineCryptoConstants() sets constants from OpenSSL into
crypto.constants, for crypto and tls. DefineOpenSSLConstants() did
exactly the same. Unify them.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22187/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22199/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22203/

[sam-github]

11:47:56   Generating code
11:47:56 c:\workspace\node-compile-windows\src\node_main.cc : fatal error C1382: the PCH file 'c:\workspace\node-compile-windows\release\obj\node\node.pch' has been rebuilt since 'c:\workspace\node-compile-windows\release\obj\node\node_main.obj' was generated. Please rebuild this object [c:\workspace\node-compile-windows\node.vcxproj]
11:47:56 LINK : fatal error LNK1257: code generation failed [c:\workspace\node-compile-windows\node.vcxproj]

That's odd, the build failed on https://ci.nodejs.org/job/node-compile-windows/25743/label=win-vs2017-x86/console

I resumed.

[sam-github]

@nodejs/build #27077 (comment) has happened twice in a row now, see the end of https://ci.nodejs.org/job/node-compile-windows/25746/label=win-vs2017-x86/consoleText, is this a known problem?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22227/

[Trott]

@nodejs/build #27077 (comment) has happened twice in a row now, see the end of https://ci.nodejs.org/job/node-compile-windows/25746/label=win-vs2017-x86/consoleText, is this a known problem?

FWIW, both times here appear to be test-rackspace-win2012r2-x64-10. Build history for that host shows 5 consecutive failures that include those two failures, but then the host recovered. I have no idea if it self-healed or if someone intervened. I also don't know if this is a known issue.

[sam-github]

@Trott Yes, I see the same thing. Its not clear if something was changed to fix it, but this just passed on Windows, too.

Yay?

[sam-github]

Landed in a3f30a4